Remove custom metrics test adapter

[astefanutti]

This PR removes the custom metrics test adapter that has been copied / pasted from the custom metrics adapter project, but that's not used and has no purpose.

[asm582]

Thanks @astefanutti

LGTM

[asm582]

/approve

[metalcycling]

Different people using MCAD for designing systems have requested that MCAD talks to Prometheus and exposes "metrics" to it. We're not doing this right now, but it may come later. Would removing this code impact that?

[asm582]

Different people using MCAD for designing systems have requested that MCAD talks to Prometheus and exposes "metrics" to it. We're not doing this right now, but it may come later. Would removing this code impact that?

Thanks @metalcycling for the review, I think it would not impact. if something is not used currently, I think we should remove it. keeping unused code in the repo calls for maintenance and hampers code coverage i.e. one needs to write additional tests

[astefanutti]

@metalcycling custom/external metrics are orthogonal to Prometheus metrics, which are going to be introduced with #486 and #573. So removing that custom metrics test adapter won't have any negative impact, neither now, nor in the future.

[asm582]

@metalcycling custom/external metrics are orthogonal to Prometheus metrics, which are going to be introduced with #486 and #573. So removing that custom metrics test adapter won't have any negative impact, neither now, nor in the future.

@metalcycling are we good to approve this PR?

[metalcycling]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582, metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [asm582,metalcycling]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metalcycling]

@astefanutti @asm582 Alrighty then. I just wanted to make sure that issue was raised somewhere, because really everyone is asking of MCAD Prometheus, whatever that means...