noticed that this exact check is done above on L264 #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
force-pushed
the
rm-redundant-check
branch
from
504ba68
to
3c6269b
Compare
astefanutti
reviewed
Aug 29, 2023
| @@ -261,7 +261,9 @@ func (qm *QuotaManager) Fits(aw *arbv1.AppWrapper, awResDemands *clusterstateapi | |||
| proposedPreemptions []*arbv1.AppWrapper) (bool, []*arbv1.AppWrapper, string) { | |||
|
|
|||
| // Handle uninitialized quota manager | |||
| // If a url does not exists then assume fits quota | |||
| if len(qm.url) <= 0 { | |||
There was a problem hiding this comment.
nit: I understand it's already there, but while we are at it, changing for equality comparison seems more idiomatic here.
|
/lgtm |
Signed-off-by: Kevin <kpostlet@redhat.com>
KPostOffice
force-pushed
the
rm-redundant-check
branch
from
3c6269b
to
427e90f
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 116b979
into
project-codeflare:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure which one encapsulated the intended behavior
What changes have been made
removed a redundant conditional
Checks