Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcad kuberay example #617

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

tedhtchang
Copy link
Member

@tedhtchang tedhtchang commented Aug 29, 2023

Issue link

closes #583

What changes have been made

  • update doc/usage/examples/kuberay/kuberay-mcad.md
  • remove raycluster-autoscaler example because currently mcad does not support

Verification steps

Follow the instruction in the modified doc/usage/examples/kuberay/kuberay-mcad.md file

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

This PR should be updated with the issue
/cc @anishasthana @kevin85421

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: kevin85421.

Note that only project-codeflare members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Issue link

closes #583

What changes have been made

  • update doc/usage/examples/kuberay/kuberay-mcad.md
  • update example appwrapper yaml

Verification steps

Follow the instruction in the modified doc/usage/examples/kuberay/kuberay-mcad.md file

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

This PR should be updated with the issue
/cc @anishasthana @kevin85421

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we want this tutorial to be based on ODH installation, but if it's the same markdown in both repos the helm install of kuberay is fine

doc/usage/examples/kuberay/kuberay-mcad.md Outdated Show resolved Hide resolved
tedhtchang and others added 3 commits August 31, 2023 00:22
Co-authored-by: Anish Asthana <anishasthana1@gmail.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
@asm582
Copy link
Member

asm582 commented Sep 6, 2023

/lgtm

@asm582
Copy link
Member

asm582 commented Sep 6, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 96ab8fa into project-codeflare:main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the kuberay-mcad.md
5 participants