Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only update etcd when preempted #633

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

asm582
Copy link
Member

@asm582 asm582 commented Sep 13, 2023

Issue link

#632

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@openshift-ci openshift-ci bot removed the lgtm label Oct 9, 2023
@jbusche
Copy link
Contributor

jbusche commented Oct 10, 2023

Hi @asm582 I was able to build and test this PR with the perf-tests.

AppWrappers     Total Time (seconds)    MCAD Image      Cluster Info    Comments
5       30 seconds      Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633
20      80 seconds      Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633
50      153 seconds     Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633
100     353 seconds     Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633
200     720 seconds     Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633
300     1116 seconds    Abishek PR 633  Fyre MEDIUM OC 412 3 Nodes, 8 cpu/16GB mem       quay.io/jbusche/mcad-controller:fix-preempt1-try1 from his pr 633

This compares very similar to release-v1.35.0 and faster than the combined codeflare-operator:v1.0.0-rc.1

I'm storing my performance runs here: https://ibm.ent.box.com/file/1182185239246

@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 1257d4b into project-codeflare:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants