Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue formatting log message #636

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

VanillaSpoon
Copy link
Member

What changes have been made

Just a small fix for the formatting of a log message. klog.Info doesn't support string formatting and will therefore display the log as [allocatableCapacity] The available capacity to dispatch appwrapper is %v and time took to calculate is %v ... without replacing the %v values.

I substituted time.Now().Sub(startTime) to time.Since(startTime) for readability.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

Nice catch 👍🏼.

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b445015 into project-codeflare:main Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants