Skip to content

Commit

Permalink
ci: use cached devcontainer in test jobs (#28)
Browse files Browse the repository at this point in the history
Lockdown of `GITHUB_TOKEN` permissions revealed that the test jobs were attempting to rebuild and push the devcontainer and failing. This change corrects the `test-patch` job in build.yaml to use the cached devcontainer from the `build` step and not attempt to push it again when the job completes.

Signed-off-by: Simon Leet <simon.leet@microsoft.com>
  • Loading branch information
CodeMonkeyLeet committed Feb 6, 2023
1 parent 3d725f8 commit 58c6b39
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ jobs:
- name: Run functional test in dev container
uses: devcontainers/ci@v0.2
with:
imageName: ${{ env.DEVCON_NAME }}
imageTag: ${{ env.DEVCON_VERSION }}
cacheFrom: ${{ env.DEVCON_NAME }}
push: never
env: |
BUILDKIT_PORT=30321
runCmd: |
Expand Down

0 comments on commit 58c6b39

Please sign in to comment.