Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add centos and amazon linux support #115

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Apr 24, 2023

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Closes #83
Closes #94

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.23 ⚠️

Comparison is base (74ae03e) 35.17% compared to head (2fe77c1) 34.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   35.17%   34.94%   -0.23%     
==========================================
  Files          12       12              
  Lines        1143     1139       -4     
==========================================
- Hits          402      398       -4     
  Misses        720      720              
  Partials       21       21              
Impacted Files Coverage Δ
pkg/pkgmgr/rpm.go 32.62% <0.00%> (ø)
pkg/pkgmgr/pkgmgr.go 12.98% <100.00%> (-4.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the centos branch 2 times, most recently from 9e3f0c1 to eb14420 Compare April 25, 2023 02:17
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan changed the title feat: add centos support feat: add centos and amazon linux support Apr 25, 2023
@sozercan sozercan marked this pull request as ready for review April 25, 2023 02:42
Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 6ac6922 into project-copacetic:main Apr 26, 2023
18 checks passed
@sozercan sozercan deleted the centos branch April 26, 2023 16:47
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: unsupported osType amazon specified [Question] Error: unsupported osType centos specified
3 participants