-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version flag #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smurawski
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
May 22, 2023 05:33
Signed-off-by: Steven Murawski <stmuraws@microsoft.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 34.94% 34.94%
=======================================
Files 12 12
Lines 1139 1139
=======================================
Hits 398 398
Misses 720 720
Partials 21 21 ☔ View full report in Codecov by Sentry. |
sozercan
reviewed
May 22, 2023
sozercan
previously approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, otherwise LGTM. Thank you!
Signed-off-by: GitHub <noreply@github.com>
sozercan
approved these changes
May 22, 2023
ashnamehrotra
pushed a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile specifies main.version in the ldflags. This PR just pulls that value into the Version property of the command, lighting up
--version
.Closes #158