Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version flag #159

Merged
merged 2 commits into from
May 22, 2023
Merged

feat: add version flag #159

merged 2 commits into from
May 22, 2023

Conversation

smurawski
Copy link
Contributor

The makefile specifies main.version in the ldflags. This PR just pulls that value into the Version property of the command, lighting up --version.

Closes #158

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Signed-off-by: Steven Murawski <stmuraws@microsoft.com>
@smurawski smurawski changed the title Add version flag feat: add version flag May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d417971) 34.94% compared to head (bb655ef) 34.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   34.94%   34.94%           
=======================================
  Files          12       12           
  Lines        1139     1139           
=======================================
  Hits          398      398           
  Misses        720      720           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

main.go Outdated Show resolved Hide resolved
sozercan
sozercan previously approved these changes May 22, 2023
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, otherwise LGTM. Thank you!

Signed-off-by: GitHub <noreply@github.com>
@sozercan sozercan merged commit fd33ed7 into project-copacetic:main May 22, 2023
23 checks passed
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] copa --version
2 participants