Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update installation instructions #19

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

salaxander
Copy link
Contributor

Signed-off-by: Xander Grzywinski xgrzywinski@microsoft.com

Add homebrew and release download methods to installation docs

Signed-off-by: Xander Grzywinski <xgrzywinski@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1abe938) compared to base (4368570).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           27        27           
=========================================
  Hits            27        27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeMonkeyLeet CodeMonkeyLeet changed the title update installation instructions docs: update installation instructions Jan 23, 2023
Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salaxander @sozercan One additional meta-comment: Release automation relies on commit title prefixes to generate release notes, so please make sure your commits are correctly tagged per contributor guidelines. As maintainers that means:

  • all commits are appropriately prefixed if using rebase merge
  • title of PR that is used as the default commit title is appropriately prefixed if using squash and merge.

salaxander and others added 2 commits January 23, 2023 13:26
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xgrzywinski@microsoft.com>

docs: update install docs

Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
@CodeMonkeyLeet
Copy link
Contributor

@salaxander while merging this I noticed that you have DCO signoffs under multiple email accounts; can you check your environments (your local git config in each clone/fork of this repo) to ensure that you are using the one recognized by github as your primary? (xgrzywinski@microsoft.com I think)

@CodeMonkeyLeet CodeMonkeyLeet merged commit 6d0e959 into project-copacetic:main Jan 24, 2023
@salaxander
Copy link
Contributor Author

@CodeMonkeyLeet Yeah my MSFT alias changed a while back and I just got round to updating it on GitHub and in my gitconfig during this PR. Should be good in the future!

ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Signed-off-by: Xander Grzywinski <xgrzywinski@microsoft.com>
Co-authored-by: Xander Grzywinski <xgrzywinski@microsoft.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants