ci: remove dev container #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 34.72% 34.72%
=======================================
Files 12 12
Lines 1146 1146
=======================================
Hits 398 398
Misses 727 727
Partials 21 21 ☔ View full report in Codecov by Sentry. |
sozercan
force-pushed
the
remove-devcontainer
branch
16 times, most recently
from
d7655c2
to
e552a9b
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
remove-devcontainer
branch
from
e552a9b
to
db391e3
Compare
cpuguy83
reviewed
Aug 10, 2023
.github/workflows/build.yml
Outdated
| docker run --net=host --detach --rm --privileged -p 127.0.0.1:8888:8888/tcp --name buildkitd --entrypoint buildkitd moby/buildkit:v${{ env.BUILDKIT_VERSION }} --addr tcp://0.0.0.0:8888 | ||
|
|
||
| echo "[INFO]: Run copa on target ..." | ||
| retry -max-time 10m ./copa patch -i "${{ matrix.image }}:${{ matrix.tag }}@${{ matrix.digest }}" -r scan.json -t "${{ matrix.tag }}-patched" -a tcp://127.0.0.1:8888 --timeout 10m |
There was a problem hiding this comment.
Would we need retry if we drop WithFailFast() on the buildkit client?
cpuguy83
approved these changes
Aug 10, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
remove-devcontainer
branch
from
75bb7dc
to
5579523
Compare
ashnamehrotra
pushed a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #<issue_ID>