Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs for new connection methods #258

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Aug 15, 2023

Closes #250

@sozercan
Copy link
Member

sozercan commented Aug 15, 2023

@cpuguy83
Copy link
Contributor Author

#258 (files) let's update this too

Added a link to the examples in our doc here.

3. To patch the image, use the Trivy report and specify a buildkit instance to connect to:

By default copa will attempt to auto-connect to an instance in order:
1. Default docker buildkit endpoint (requires at least docker v24.0 with [containerd snapshotter]() support enabled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Fixed

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like missing a link for containerd snapshotter. lgtm otherwise, thank you!

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
@sozercan sozercan merged commit cbf4117 into project-copacetic:main Aug 16, 2023
6 checks passed
@cpuguy83 cpuguy83 deleted the connection_docs branch August 16, 2023 00:25
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC] add docs for buildkit integration
2 participants