Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle mariner zstd compression #295

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Sep 7, 2023

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

handle mariner zstd compression as busybox rpm does not support zstd compression

Switch rpm package building to use to zstd compression level 7
https://github.com/microsoft/CBL-Mariner/releases/tag/2.0.20230805-2.0

this should fix the broken e2e

Closes #<issue_ID>

Copy link
Contributor

@salaxander salaxander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice to see DCO is working again too 😆

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (4182a4c) 31.78% compared to head (86d73de) 31.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   31.78%   31.80%   +0.01%     
==========================================
  Files          18       18              
  Lines        1598     1597       -1     
==========================================
  Hits          508      508              
+ Misses       1062     1061       -1     
  Partials       28       28              
Files Changed Coverage Δ
pkg/pkgmgr/rpm.go 33.76% <0.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan merged commit d89e401 into project-copacetic:main Sep 7, 2023
16 checks passed
@sozercan sozercan deleted the fix-mariner-compress branch September 7, 2023 19:31
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Sep 22, 2023
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Sep 22, 2023
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>

Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
ashnamehrotra added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants