Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not upgrade held packages #457

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Jan 3, 2024

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Removing this flag as it is not recommended by apt

       --allow-change-held-packages
           Force yes; this is a dangerous option that will cause apt to continue without
           prompting if it is changing held packages. It should not be used except in very
           special situations. Using it can potentially destroy your system! Configuration Item:
           APT::Get::allow-change-held-packages. Introduced in APT 1.1.

https://manpages.ubuntu.com/manpages/xenial/man8/apt-get.8.html

Closes #<issue_ID>

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5ddc6bc) 32.59% compared to head (b6a8377) 32.59%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/pkgmgr/dpkg.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   32.59%   32.59%           
=======================================
  Files          17       17           
  Lines        1617     1617           
=======================================
  Hits          527      527           
  Misses       1058     1058           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozercan sozercan changed the title chore: keep held packages fix: do not upgrade held packages Jan 4, 2024
@sozercan sozercan marked this pull request as ready for review January 4, 2024 00:34
@sozercan sozercan marked this pull request as draft January 4, 2024 00:34
@sozercan sozercan requested a review from cpuguy83 January 9, 2024 22:04
@sozercan sozercan marked this pull request as ready for review January 9, 2024 22:04
@sozercan sozercan merged commit a15c13e into project-copacetic:main Jan 9, 2024
17 checks passed
@sozercan sozercan deleted the remove-held-pkgs branch January 9, 2024 23:43
@sozercan sozercan mentioned this pull request Feb 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants