Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add best practices for patching and tagging #497

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

salaxander
Copy link
Contributor

Took an initial try at this. Open to feedback to improve the examples and wording

Closes #476

website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
@sozercan
Copy link
Member

sozercan commented Feb 7, 2024

fyi @johnsonshi

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2602d59) 32.51% compared to head (4be5888) 34.18%.
Report is 3 commits behind head on main.

❗ Current head 4be5888 differs from pull request most recent head 4b38186. Consider uploading reports for the commit 4b38186 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   32.51%   34.18%   +1.67%     
==========================================
  Files          17       17              
  Lines        1621     1293     -328     
==========================================
- Hits          527      442      -85     
+ Misses       1062      819     -243     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 5 commits February 7, 2024 09:44
…acetic#486)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
…9.0 (project-copacetic#495)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor leftovers, otherwise lgtm

website/docs/best-practices.md Outdated Show resolved Hide resolved
website/docs/best-practices.md Outdated Show resolved Hide resolved
salaxander and others added 2 commits February 7, 2024 10:05
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
@salaxander salaxander merged commit 8a9264f into project-copacetic:main Feb 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC] best practices for patched tags
3 participants