Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore CVE-2024-0567 and CVE-2023-5981 to fix ci #506

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

salaxander
Copy link
Contributor

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Closes #<issue_ID>

Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2602d59) 32.51% compared to head (01b930a) 34.18%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   32.51%   34.18%   +1.67%     
==========================================
  Files          17       17              
  Lines        1621     1293     -328     
==========================================
- Hits          527      442      -85     
+ Misses       1062      819     -243     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
@salaxander
Copy link
Contributor Author

@sozercan would we still expect the CI to be failing with this PR?

@sozercan
Copy link
Member

@salaxander sounds like issues have not been addressed. you can test individually or add them back in

This reverts commit 249eb8e.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
Copy link
Member

sozercan commented Feb 16, 2024

reverting last commit to unblock #508

@salaxander
Copy link
Contributor Author

Still seeing failures :(. The tests orginally failed before I had cleared those other 2 CVEs too

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@ashnamehrotra
Copy link
Contributor

the trivy command and file looks correct in the test logs, https://github.com/ashnamehrotra/copacetic/actions/runs/7938093411/job/21676447774#step:9:101 but copa is still checking for the error https://github.com/ashnamehrotra/copacetic/actions/runs/7938093411/job/21676447774#step:9:1897. Maybe it could be something within trivy?

@sozercan
Copy link
Member

looks like CVE-2023-5981 is also marked as needing u5 so ignoring that too, this should fix it i think

@sozercan
Copy link
Member

sozercan commented Feb 17, 2024

@ashnamehrotra fyi - it was hard to test since it was just locking without your pr without giving the error, i merged them both in #509 to test

@sozercan sozercan changed the title ci: ignore CVE-2024-0567 to fix ci ci: ignore CVE-2024-0567 and CVE-2023-5981 to fix ci Feb 17, 2024
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan merged commit 5274edf into project-copacetic:main Feb 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants