feat: add http proxy support when executing package managers #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derdanne
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
derdanne
force-pushed
the
feature/add-http-proxy-support
branch
2 times, most recently
from
a74c090
to
bd4949f
Compare
sozercan
reviewed
Mar 23, 2023
derdanne
force-pushed
the
feature/add-http-proxy-support
branch
from
c0bbd97
to
34a4cfd
Compare
Signed-off-by: Daniel Klockenkämper <daniel.klockenkaemper@gmx.de>
Signed-off-by: Daniel Klockenkämper <daniel.klockenkaemper@gmx.de>
derdanne
force-pushed
the
feature/add-http-proxy-support
branch
from
34a4cfd
to
30d8992
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 34.36% 35.17% +0.80%
==========================================
Files 12 12
Lines 1129 1143 +14
==========================================
+ Hits 388 402 +14
Misses 720 720
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
One of the tests are failing, but I don't think this is related to this. Investigating. |
ashnamehrotra
pushed a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
…-copacetic#79) Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add http proxy support when executing package managers.
Closes #80