Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove grafana image renderer test #86

Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Mar 28, 2023

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Remove grafana image renderer test to unblock the CI

This image is using alpine edge repo so it is not suitable for this: https://github.com/grafana/grafana-image-renderer/blob/master/Dockerfile#L9-L11

Closes #<issue_ID>

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan changed the title remove grafana image renderer test test: remove grafana image renderer test Mar 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (282835d) 34.36% compared to head (827e084) 34.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          12       12           
  Lines        1129     1129           
=======================================
  Hits          388      388           
  Misses        720      720           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 397b611 into project-copacetic:main Mar 28, 2023
@sozercan sozercan deleted the remove-grafana-renderer-test-image branch March 28, 2023 23:56
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants