Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/middleware - Expose the receiverNumber during the onCall callback middleware #1119

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

tofudeadeye
Copy link
Contributor

@tofudeadeye tofudeadeye commented Jan 15, 2024

Pull Request Description

In certain cases you want to know the receiving number configured within the scope of the onCall middleware callback. This exposes the "receiverNumber" so it would be accessible within the callback as ctx.receiverNumber.

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

…k middleware

In certain cases you want to know the receiving number configured for the callback, this exposes the "receiverNumber" so it would be accessible within the callback as `ctx.receiverNumber`
@itschip
Copy link
Member

itschip commented Jan 19, 2024

LGTM! Thanks!

@itschip itschip merged commit 3d0e4d9 into project-error:master Jan 19, 2024
4 checks passed
@tofudeadeye tofudeadeye deleted the patch-1 branch January 20, 2024 03:14
antonstjernquist pushed a commit to antonstjernquist/npwd that referenced this pull request Jan 26, 2024
…k middleware (project-error#1119)

In certain cases you want to know the receiving number configured for the callback, this exposes the "receiverNumber" so it would be accessible within the callback as `ctx.receiverNumber`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants