Fixed an explicit SQL error about dark_chat tables #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng when creating a darkchat related table.
|
LGTM |
|
Thank you for fixing this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an explicit SQL error that caused the UNIQUE INDEX to be too long when creating a dark chat related table.
According to the MySQL INNODB limit, when using the utf8mb4 character set, you cannot set a UNIQUE INDEX longer than 191 characters. On line 208 of import.sql, the community developer misidentifies the 255 character column defined on line 205 as the index. This caused MySql to fail to execute the statement, which in turn caused the last three data tables to fail to be created. A workaround for reference is to "change" VARCHAR(255) to "VARCHAR(191)" in line 205, but you can also set 191 to any number less than it you like.
Reference: https://dev.mysql.com/doc/refman/8.0/en/innodb-limits.html