Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow test run marks the activities under a branch whose condition is set to false #421

Closed
apandura-tibco opened this issue Jun 5, 2017 · 3 comments

Comments

@apandura-tibco
Copy link
Collaborator

apandura-tibco commented Jun 5, 2017

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
When I test run a flow with a branch having false condition, it marks the tiles under the branch as run though it did not run them in actual case.
image

Expected behavior
The test flow run should not mark the activities under the branch with false condition as run.

Minimal reproduction of the problem with instructions

  1. Open a flow which has a branch with "false" condition in it as shown in the above screenshot.
  2. Select any tile (Activity or Trigger) and click on "Run from Trigger" button from the right hand side details panel.
  3. Notice that even the branch condition is set to false, the activities under the branch marked as run state.
  • Flogo version: 0.3.4
@apandura-tibco apandura-tibco changed the title Flow test run executing the branch which is under false condition Flow test run marks the activities under a branch whose condition is set to false Jun 5, 2017
@apandura-tibco apandura-tibco added this to the 0.4.0 milestone Jun 15, 2017
@apandura-tibco apandura-tibco self-assigned this Jun 15, 2017
@apandura-tibco
Copy link
Collaborator Author

We noticed the following problems when we test run the flow from trigger:

  • The response of run/instance/***/steps is not having sufficient data through which we can consider if the task is run or not.
  • The response of run/instance/***/steps has changed from v0.3.2 to v0.3.4.

Sharing the response JSON's for v0.3.2 and v0.3.4 in slack channel.

@smanu smanu modified the milestones: 0.4.1, 0.4.0 Jul 24, 2017
@fcastill fcastill modified the milestones: 0.4.2, 0.4.1 Aug 17, 2017
apandura-tibco added a commit that referenced this issue Nov 16, 2017
…here the state of a step decides whether the task is skipped or not
fcastill added a commit that referenced this issue Nov 17, 2017
Test run flow - Fix to the UI representation for a task state of a flow #421
@fcastill
Copy link
Collaborator

Accidentally closed. UI fixed is checked in but engine still needs to be fixed, once verified we can close this issue.

@fcastill fcastill reopened this Nov 18, 2017
@apandura-tibco
Copy link
Collaborator Author

The steps API call is responding with the taskState for each step which defines which steps are skipped. Closing the issue as the problem is solved now.

Also checked that the string comparison check issue (issue 1) in flogo/issues/#54 is also fixed in flogo-web / engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants