add target to validate swagger with spectral #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
reviewed
Mar 30, 2022
Makefile
Outdated
| @@ -197,6 +197,9 @@ ifeq (, $(shell which ginkgo)) | |||
| $(call go-get-tool,$(GINKGO),github.com/onsi/ginkgo/ginkgo@v1.16.5) | |||
| endif | |||
|
|
|||
| validate-swagger: ## Validate swagger | |||
| $(DOCKER) run -it --rm -v $(PWD)/.spectral.yaml:/tmp/.spectral.yaml -v $(PWD)/swagger.yaml:/tmp/swagger.yaml stoplight/spectral lint --ruleset "/tmp/.spectral.yaml" /tmp/swagger.yaml | |||
There was a problem hiding this comment.
pls remove trailing whitespace
There was a problem hiding this comment.
Could the use of mktemp be more appropriate and consistent with the rest of the Makefile?
There was a problem hiding this comment.
don't think it is needed here. the file should exist only inside a container that will be removed after the execution ends.
masayag
approved these changes
Mar 30, 2022
|
@tupyy Welcome and Thank you! :-) |
|
@masayag @gciavarrini Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue #155.
The rules set is the default one for OpenAPI.