Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge auto config controller #302

Closed
wants to merge 8 commits into from
Closed

Edge auto config controller #302

wants to merge 8 commits into from

Conversation

vitu1234
Copy link

@vitu1234 vitu1234 commented May 24, 2023

Description

Please include a summary of the changes and the related issue.
Why is this change required? What problem does it solve?
If it fixes an open issue, please add a link to the issue here.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Current behaviour

What is the current behavior?

New behavior

What is the new behavior?

How to reproduce (for bugs)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Documentation

If this change requires a documentation update, please add a link to the corresponding PR.

PR # (link)

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have written adequate documentation informing people about the changes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have described tests that verify my changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

Hi @vitu1234. Thanks for your PR.

I'm waiting for a project-flotta member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitu1234
Once this PR has been reviewed and has the lgtm label, please assign jordigilh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vitu1234 vitu1234 closed this May 24, 2023
@masayag
Copy link
Collaborator

masayag commented May 24, 2023

/ok-to-test

@masayag
Copy link
Collaborator

masayag commented May 24, 2023

@masayag
Copy link
Collaborator

masayag commented May 24, 2023

@vitu1234 in order to bump go version, the github workflows need to be updated as well to support the newer version:
https://github.com/project-flotta/flotta-operator/blob/main/.github/workflows/go.yml#L20
https://github.com/project-flotta/flotta-operator/blob/main/.github/workflows/kind.yaml#L27

It will be easier to review by splitting this PR to two separate PRs:

  1. Bumping golang version to 1.20
  2. Other changes introduced in this PR for the operator.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@vitu1234: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-fast 51eda86 link true /test unit-fast

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vitu1234 vitu1234 closed this by deleting the head repository Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants