Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN complain for non-standard things in the check directory ... NOTE #6

Closed
ohagen opened this issue Apr 6, 2020 · 15 comments
Closed
Labels
bug Something isn't working

Comments

@ohagen
Copy link
Member

ohagen commented Apr 6, 2020

* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
  'examples_i386' 'examples_x64' 'gen3sis-Ex_i386.Rout'
  'gen3sis-Ex_x64.Rout' 'tests_i386' 'tests_x64'

The above happens when checking the package.

@ohagen ohagen added bug Something isn't working good first issue Good for newcomers labels Apr 6, 2020
@benj919
Copy link
Collaborator

benj919 commented Apr 16, 2020

As far as I can see this is a problem with rhub/cran, not the package itself... They might just ignore it on a submission.

@benj919 benj919 closed this as completed Apr 16, 2020
@florianhartig
Copy link
Member

Is this when you check locally, or with winbuilder? If you get such a message on incoming, you will nearly certainly be asked to fix this.

@benj919
Copy link
Collaborator

benj919 commented Apr 16, 2020

From my discussion with Oskar these files don't show up when building and checking locally on windows (with --as-cran)

@ohagen
Copy link
Member Author

ohagen commented Apr 16, 2020

they still appear! I will reopen the issue until it's fixed

@ohagen ohagen reopened this Apr 16, 2020
@florianhartig
Copy link
Member

Ok, when this doesn't show up when checked with https://win-builder.r-project.org/upload.aspx, it should be fine

@florianhartig
Copy link
Member

So, for me, the CRAN checks break already with the vignette, at

# TOADD a plot of richenss over time
load(file.path(datapath, "output/config_rte/sgen3sis.RData"))
#get total richness per time interval
rt <- colSums(sgen3sis$geo_richness[,-c(1,2)], na.rm = T)
#plot
plot(rt, type='l')

are you sure that this is running through? Regardless, to fix this, first thing I would do is to get the CI running (see #9), this will give you a good hint how things look on a clean system, and then we can take it from there.

@ohagen
Copy link
Member Author

ohagen commented May 4, 2020

I will update the vignette. Never did CI, so happy to support you as you tell me.

@ohagen
Copy link
Member Author

ohagen commented May 4, 2020

Vignette should be working now. I changed the output system but still had the old sgen3sis object on my package folder! Thanks for spotting this out. Should work now regarding the vignette. Let me know what I should do regarding the CI

@florianhartig
Copy link
Member

So, I don't get any of these non-standard files in my tests. Are you still getting this?

@florianhartig
Copy link
Member

I think this is something from your local computers - do you actually see these files? Have you tried just erasing them?

@florianhartig florianhartig removed the good first issue Good for newcomers label May 12, 2020
@benj919
Copy link
Collaborator

benj919 commented May 12, 2020

I don't get this, but I'm on Ubuntu. Initially those files only showed up when checking with R-devel iirc...

@florianhartig
Copy link
Member

So, who exactly can reproduce this problem, and if someone can reproduce it, could you describe exactly the circumstances under which this occurs?

If no one can reproduce it, I guess we should close this!

@florianhartig
Copy link
Member

Oskar, check again if #25 is solved, I expect that this will be gone

@ohagen
Copy link
Member Author

ohagen commented May 18, 2020

#25 is fixed. Thanks! Can we close this? What do you get on mac when checking on -as --CRAN?

@florianhartig
Copy link
Member

In never got a problem. Will close, you can re-open if this is showing up in any of the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants