Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tests / continuous integration #9

Closed
florianhartig opened this issue Apr 16, 2020 · 7 comments
Closed

Automatic tests / continuous integration #9

florianhartig opened this issue Apr 16, 2020 · 7 comments

Comments

@florianhartig
Copy link
Member

Hi guys,

just as we talked about the tests - you haven't set up CI tests yet, right? There are at least two options, Travis CI, which I do for DHARMa, and there is a new option directly via GitHub workflows, see an example here https://github.com/TheoreticalEcology/s-jSDM/actions

The advantage of using the workflows is that a) I think it can also be done on a private repo b) it also tests Windows and MacOS. Advantage of TravisCI is that it looks nicer (in my opinion), especially when you work a lot with branches.

Anyway, we should decide for one or the other, this will help a lot with the tests and questions such as #6

@benj919
Copy link
Collaborator

benj919 commented Apr 16, 2020

I have a preference for the workflows approach as it versions the build / test scripts with the repo. I haven't work with either though. And do you know what each option costs?

@florianhartig
Copy link
Member Author

Both are free for open source projects ... because it's faster, I will now add a Travis file, and you can add the workflow if you find the time, we can then see what works better.

@florianhartig
Copy link
Member Author

I have pushed a Travis file, but I think the owner of the repo has to activate this, at least I can't see the results. I requested the rights from you too.

@ohagen
Copy link
Member

ohagen commented May 4, 2020

access granted

@florianhartig
Copy link
Member Author

no, that didn't work, I don't have the rights. Do you see something at https://travis-ci.com/github/project-Gen3sis/R-package ?

@florianhartig
Copy link
Member Author

I still can't do it - I think you have to activate it Oskar - I can know see now

https://travis-ci.org/github/project-Gen3sis/R-package

but I'm getting

This is not an active repository
You don't have sufficient rights to enable this repo on Travis.
Please contact the admin to enable it or to receive admin rights yourself.

@florianhartig
Copy link
Member Author

Hi all, continous integration is working now, ideally sign up to Travis so that you get emails when a build fails, or else check whenever you commit something https://travis-ci.com/github/project-Gen3sis/R-package/branches

The link is also on the main page.

I have mentioned this before, in order to make this work properly, any time you implement a new feauture

  • create a branch
  • do your changes in the branch
  • publish the branch, or better: create a pull request, which will trigger the CI tests to run
  • if it works, merge back into the master branch

If you do this systematically, the master branch should always be clean / working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants