Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few changes for JclCompilerUtils & JclIDEUtils #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tdelphi
Copy link

@tdelphi tdelphi commented Aug 15, 2014

Here are few changes (non-breaking) for JclCompilerUtils & JclIDEUtils.

@tdelphi
Copy link
Author

tdelphi commented Oct 2, 2014

Hi!

This pull request is ignored for some time. Why?

@obones
Copy link
Member

obones commented Oct 5, 2014

Hello,

Well it did not get ignored, it's just that we are but a few people active on the project and we have very little spare time.
This means that unless a pull request is very well formed, it gets postponed.
In your case, this postponing came from the fact that your pull request contains unrelated changes, some of which I have a hard time understanding the point. This means that I can't merge it easily and so don't have the time to do so.
The basic rule is "one feature/one branch/one pull request".
I have made comments on your commits individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants