Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial changes for upgrade to web-pack-dev server 4.0.0 #1928

Merged

Conversation

ddonahue007
Copy link
Contributor

@ddonahue007 ddonahue007 commented Mar 23, 2021

@@ -199,15 +199,15 @@ module.exports = (_env, argv) => {
],
},
devServer: {
stats,
contentBase: false,
host: 'localhost',
Copy link
Contributor

@dlabrecq dlabrecq Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need host: 'localhost'?

I commented it out and restarted, but this doesn't appear to do anything -- maybe it's the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not add it when you start up the message for host is blank, maybe it uses `localhost by default. I thought it best to explicitly call it out.

This is with out it set

yarn start:dev
yarn run v1.22.10
$ APP_ENV=proxy yarn start
$ NODE_OPTIONS=--max-old-space-size=8192 webpack serve -c ./webpack.config.js
⬡ wds: ~~~Using variables~~~
⬡ wds: isProduction: false
⬡ wds: Current branch: master
⬡ wds: Beta branches: master,qa-beta,ci-beta,prod-beta
⬡ wds: Using deployments: beta/apps
⬡ wds: Public path: /beta/apps/cost-management/
⬡ wds: ~~~~~~~~~~~~~~~~~~~~~
[webpack-dev-server] Project is running at http://[::]:8002/<-------------- SEE HERE
[webpack-dev-server] 404s will fallback to /beta/apps/cost-management/index.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense now. Thanks

@dlabrecq dlabrecq merged commit 748378e into project-koku:master Mar 23, 2021
@ddonahue007 ddonahue007 deleted the upgrade-webpack-dev-server_cost-1185 branch March 24, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants