Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PatternFly shared modules #1981

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jun 9, 2021

This simplifies webpack using singleton: false for PatternFly shared modules. Also added version ranges to PatternFly packages for shared module matching.

@dlabrecq dlabrecq requested a review from ddonahue007 June 9, 2021 02:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #1981 (d56e4cd) into master (f84c409) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1981   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         372      372           
  Lines        6829     6829           
  Branches     1464     1464           
=======================================
  Hits         4864     4864           
  Misses       1941     1941           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f84c409...d56e4cd. Read the comment docs.

Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabrecq dlabrecq merged commit 98eb052 into project-koku:master Jun 9, 2021
@dlabrecq dlabrecq deleted the shared-mod branch June 9, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants