Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift Infrastructure chart #1983

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jun 9, 2021

Added OpenShift Infrastructure perspective to overview. This moves the infrastructure data, from the "All" perspective, to its own chart. This new perspective mimics the supplementary view.

https://issues.redhat.com/browse/COST-1491

New "OpenShift infrastructure" perspective

Screen Shot 2021-06-09 at 10 30 07 AM

New "All OpenShift" perspective

Screen Shot 2021-06-09 at 10 30 29 AM

Old "All" perspective

Screen Shot 2021-06-09 at 10 50 58 AM

@dlabrecq dlabrecq requested a review from ddonahue007 June 9, 2021 14:44
Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1983 (88d998a) into master (0dfa968) will decrease coverage by 0.25%.
The diff coverage is 54.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
- Coverage   71.22%   70.97%   -0.26%     
==========================================
  Files         372      378       +6     
  Lines        6829     6938     +109     
  Branches     1464     1491      +27     
==========================================
+ Hits         4864     4924      +60     
- Misses       1941     1987      +46     
- Partials       24       27       +3     
Impacted Files Coverage Δ
...ponents/charts/dailyTrendChart/dailyTrendChart.tsx 8.33% <0.00%> (-0.30%) ⬇️
.../views/overview/components/dashboardWidgetBase.tsx 38.07% <0.00%> (-0.33%) ⬇️
src/store/dashboard/common/dashboardCommon.ts 100.00% <ø> (ø)
...tore/dashboard/ocpDashboard/ocpDashboardWidgets.ts 100.00% <ø> (ø)
...ntaryDashboard/ocpSupplementaryDashboardWidgets.ts 100.00% <ø> (ø)
...tureDashboard/ocpInfrastructureDashboardActions.ts 32.00% <32.00%> (ø)
...ctureDashboard/ocpInfrastructureDashboardCommon.ts 42.30% <42.30%> (ø)
...reDashboard/ocpInfrastructureDashboardSelectors.ts 50.00% <50.00%> (ø)
src/components/charts/trendChart/trendChart.tsx 81.57% <60.00%> (-0.99%) ⬇️
...tureDashboard/ocpInfrastructureDashboardReducer.ts 83.33% <83.33%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfa968...88d998a. Read the comment docs.

@dlabrecq dlabrecq merged commit 6fbeadb into project-koku:master Jun 9, 2021
@dlabrecq dlabrecq deleted the 1491-infra-chart branch June 9, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants