Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cone of confidence legend item #1985

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jun 9, 2021

Updated the charts to show the forecast cone of confidence as its own legend item. I also used that new left-pointed triangle I created for PatternFly charts

https://issues.redhat.com/browse/COST-1492

Cumulative view
Screen Shot 2021-06-09 at 1 37 00 PM

Daily view
Screen Shot 2021-06-09 at 1 47 33 PM

@dlabrecq dlabrecq requested a review from ddonahue007 June 9, 2021 17:40
@dlabrecq dlabrecq changed the title Forecast cone of confidence is now its own legend item Cone of confidence legend item Jun 9, 2021
Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #1985 (2c4cf01) into master (6fbeadb) will increase coverage by 0.06%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
+ Coverage   70.97%   71.03%   +0.06%     
==========================================
  Files         378      378              
  Lines        6938     6937       -1     
  Branches     1491     1492       +1     
==========================================
+ Hits         4924     4928       +4     
+ Misses       1987     1983       -4     
+ Partials       27       26       -1     
Impacted Files Coverage Δ
...ponents/charts/dailyTrendChart/dailyTrendChart.tsx 8.21% <0.00%> (-0.12%) ⬇️
...tore/dashboard/ocpDashboard/ocpDashboardWidgets.ts 100.00% <ø> (ø)
src/components/charts/trendChart/trendChart.tsx 81.51% <77.77%> (-0.07%) ⬇️
src/components/charts/common/chartUtils.ts 65.93% <100.00%> (+5.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fbeadb...2c4cf01. Read the comment docs.

@dlabrecq dlabrecq merged commit 2a851a3 into project-koku:master Jun 9, 2021
@dlabrecq dlabrecq deleted the 1492-legend-items branch June 9, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants