Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS accounts typeahead #1989

Merged
merged 10 commits into from
Jun 15, 2021
Merged

AWS accounts typeahead #1989

merged 10 commits into from
Jun 15, 2021

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jun 15, 2021

Added typeahead support to the AWS details page and cost explorer.

Currently only AWS accounts are supported by the resource-types API. In addition, the resource-types/aws-accounts API does not currently support account aliases.

https://issues.redhat.com/browse/COST-1494

chrome-capture

@dlabrecq dlabrecq added the DO NOT MERGE don't merge because it's blocked or in progress label Jun 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1989 (04fc104) into master (5b0f313) will increase coverage by 0.15%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
+ Coverage   71.03%   71.19%   +0.15%     
==========================================
  Files         378      386       +8     
  Lines        6937     7036      +99     
  Branches     1492     1506      +14     
==========================================
+ Hits         4928     5009      +81     
- Misses       1983     2001      +18     
  Partials       26       26              
Impacted Files Coverage Δ
src/api/queries/query.ts 34.54% <ø> (ø)
src/api/resources/resourceUtils.ts 25.00% <25.00%> (ø)
src/api/resources/awsResource.ts 40.00% <40.00%> (ø)
src/api/resources/resource.ts 100.00% <100.00%> (ø)
src/store/resources/index.ts 100.00% <100.00%> (ø)
src/store/resources/resourceActions.ts 100.00% <100.00%> (ø)
src/store/resources/resourceCommon.ts 100.00% <100.00%> (ø)
src/store/resources/resourceReducer.ts 100.00% <100.00%> (ø)
src/store/resources/resourceSelectors.ts 100.00% <100.00%> (ø)
src/store/rootReducer.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b0f313...04fc104. Read the comment docs.

Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabrecq dlabrecq changed the title Type-ahead support AWS type-ahead support Jun 15, 2021
@dlabrecq dlabrecq changed the title AWS type-ahead support AWS accounts type-ahead support Jun 15, 2021
@dlabrecq dlabrecq changed the title AWS accounts type-ahead support AWS accounts type-ahead Jun 15, 2021
@dlabrecq dlabrecq removed the DO NOT MERGE don't merge because it's blocked or in progress label Jun 15, 2021
@dlabrecq dlabrecq merged commit 3147d10 into project-koku:master Jun 15, 2021
@dlabrecq dlabrecq changed the title AWS accounts type-ahead AWS accounts typeahead Jun 15, 2021
@dlabrecq dlabrecq deleted the 1494-type-ahead branch June 30, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants