Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost model empty state not displaying when no models #1992

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Jun 16, 2021

Refactored cost models' empty state to test user filters only.

Instead of looking at query params; limit and offset, it would be best to test if the name, description, and source_type have been filtered. In addition, there's no need to test ordering -- the empty state should be shown, regardless.

https://issues.redhat.com/browse/COST-1518

Empty state
Screen Shot 2021-06-15 at 11 21 11 PM

No match
Screen Shot 2021-06-15 at 11 22 01 PM

Loading
Screen Shot 2021-06-15 at 11 22 54 PM (2)

@codecov-commenter
Copy link

Codecov Report

Merging #1992 (73c9106) into master (0058c88) will increase coverage by 0.67%.
The diff coverage is 58.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
+ Coverage   70.51%   71.19%   +0.67%     
==========================================
  Files         307      386      +79     
  Lines        5392     7036    +1644     
  Branches     1083     1507     +424     
==========================================
+ Hits         3802     5009    +1207     
- Misses       1482     2001     +519     
+ Partials      108       26      -82     
Impacted Files Coverage Δ
src/api/forecasts/awsCloudForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/forecasts/awsForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/forecasts/azureCloudForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/forecasts/azureForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/forecasts/ocpCloudForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/forecasts/ocpForecast.ts 40.00% <0.00%> (-26.67%) ⬇️
src/api/queries/providersQuery.ts 80.00% <0.00%> (ø)
src/api/reports/gcpReports.ts 100.00% <ø> (ø)
src/api/tags/gcpTags.ts 100.00% <ø> (ø)
...components/async/asyncComponent/asyncComponent.tsx 100.00% <ø> (ø)
... and 369 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3147d10...73c9106. Read the comment docs.

Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabrecq dlabrecq merged commit a8a01f3 into project-koku:master Jun 16, 2021
@dlabrecq dlabrecq deleted the 1518-empty-state branch June 30, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants