Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tech-debt #2439

Merged
merged 5 commits into from
Sep 3, 2022
Merged

Clean up tech-debt #2439

merged 5 commits into from
Sep 3, 2022

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Sep 3, 2022

More tech-debt clean up

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #2439 (51c7bd2) into main (502c006) will increase coverage by 0.85%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2439      +/-   ##
==========================================
+ Coverage   70.36%   71.21%   +0.85%     
==========================================
  Files         436      427       -9     
  Lines        8121     7927     -194     
  Branches     1898     1837      -61     
==========================================
- Hits         5714     5645      -69     
+ Misses       2404     2175     -229     
- Partials        3      107     +104     
Impacted Files Coverage Δ
src/components/userAccess/userAccess.tsx 62.50% <50.00%> (ø)
src/components/userAccess/index.ts 100.00% <100.00%> (ø)
src/routes.tsx 86.20% <100.00%> (ø)
src/utils/cookie.ts 58.33% <0.00%> (ø)
src/utils/format.ts 67.00% <0.00%> (ø)
src/api/orgs/orgUtils.ts 37.50% <0.00%> (ø)
src/api/queries/query.ts 43.85% <0.00%> (ø)
src/utils/localStorage.ts 78.66% <0.00%> (ø)
src/store/metrics/selectors.ts 75.86% <0.00%> (ø)
src/api/resources/resourceUtils.ts 17.18% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502c006...51c7bd2. Read the comment docs.

@dlabrecq dlabrecq merged commit b775fda into project-koku:main Sep 3, 2022
@dlabrecq dlabrecq deleted the cleanup branch September 9, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants