Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify permission components to use React.FC #2442

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

dlabrecq
Copy link
Contributor

@dlabrecq dlabrecq commented Sep 9, 2022

This simplifies the following to be functional components -- mimics the HCS UI. These components are used on every page and don't need state.

  • PageTitle
  • Permissions
  • UserAccess

https://issues.redhat.com/browse/COST-2996

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #2442 (2e89fa5) into main (b775fda) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2442      +/-   ##
==========================================
+ Coverage   71.21%   71.22%   +0.01%     
==========================================
  Files         427      427              
  Lines        7927     7927              
  Branches     1838     1837       -1     
==========================================
+ Hits         5645     5646       +1     
+ Misses       2279     2174     -105     
- Partials        3      107     +104     
Impacted Files Coverage Δ
src/components/userAccess/userAccess.tsx 75.00% <66.66%> (+12.50%) ⬆️
src/utils/cookie.ts 58.33% <0.00%> (ø)
src/utils/format.ts 67.00% <0.00%> (ø)
src/api/orgs/orgUtils.ts 37.50% <0.00%> (ø)
src/api/queries/query.ts 43.85% <0.00%> (ø)
src/utils/localStorage.ts 78.66% <0.00%> (ø)
src/store/metrics/selectors.ts 75.86% <0.00%> (ø)
src/api/resources/resourceUtils.ts 17.18% <0.00%> (ø)
src/components/exports/exportsLink.tsx 43.75% <0.00%> (ø)
src/routes/components/currency/currency.tsx 31.25% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b775fda...2e89fa5. Read the comment docs.

@gitdallas gitdallas merged commit 3510b21 into project-koku:main Sep 9, 2022
@dlabrecq dlabrecq deleted the 2996-permissions branch September 12, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants