-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CostModelWizard): 3145 distribution step (crawl) #2651
feat(CostModelWizard): 3145 distribution step (crawl) #2651
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2651 +/- ##
==========================================
- Coverage 65.70% 65.63% -0.08%
==========================================
Files 451 452 +1
Lines 8918 8944 +26
Branches 2081 1939 -142
==========================================
+ Hits 5860 5870 +10
- Misses 3055 3071 +16
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the backend pushed support to stage and/or prod? I noticed the cost-model request didn't error with the new properties.
If the backend isn't ready, you could wrap this feature in an Unleash toggle? That way, we can merge your code to main.
@@ -1461,6 +1495,12 @@ export default defineMessages({ | |||
'https://access.redhat.com/documentation/en-us/cost_management_service/2022/html-single/using_cost_models/index#cost-model-terminology', | |||
id: 'docsCostModelTerminology', | |||
}, | |||
docsCostModelsDistribution: { | |||
defaultMessage: | |||
'https://access.redhat.com/documentation/en-us/cost_management_service/2022/html/using_cost_models/assembly-setting-up-cost-models#creating-an-AWS-Azure-cost-model_setting-up-cost-models', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL takes me to the same place as the "learn more" link used in the previous step.
See the docsConfigCostModels message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sketches currently have the same URL listed in both places https://www.sketch.com/s/cc6b3d35-a41c-4810-bdd8-4f70a6a3e4e5/a/AxvKMPr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm with Natalie/Ben. Maybe that is just a placeholder, but don't believe the two steps should reference the same link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did add a new placeholder... same url but using a unique intl message so when we get a new url we can just replace it there.
1e72399
to
bde16bd
Compare
@dlabrecq - looking at putting this behind unleash... i've kinda had to move things around a bit and if i have this as a flag, i'm not 100% sure how to go about it. would i keep all the changes and just hide the two new options? |
bde16bd
to
9f61c29
Compare
closes: https://issues.redhat.com/browse/COST-3145