Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CostModelWizard): 3145 distribution step (crawl) #2651

Merged
merged 8 commits into from
Nov 11, 2022

Conversation

gitdallas
Copy link
Collaborator

@gitdallas gitdallas commented Oct 31, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #2651 (f4d7fdb) into main (32530a9) will decrease coverage by 0.07%.
The diff coverage is 34.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
- Coverage   65.70%   65.63%   -0.08%     
==========================================
  Files         451      452       +1     
  Lines        8918     8944      +26     
  Branches     2081     1939     -142     
==========================================
+ Hits         5860     5870      +10     
- Misses       3055     3071      +16     
  Partials        3        3              
Impacted Files Coverage Δ
src/api/costModels.ts 90.90% <ø> (ø)
src/locales/messages.ts 100.00% <ø> (ø)
...rc/routes/costModels/components/rateForm/utils.tsx 86.27% <ø> (ø)
...routes/costModels/createCostModelWizard/context.ts 16.00% <0.00%> (-1.40%) ⬇️
...odels/createCostModelWizard/generalInformation.tsx 45.71% <ø> (ø)
...routes/costModels/createCostModelWizard/review.tsx 34.14% <0.00%> (-1.76%) ⬇️
.../routes/costModels/createCostModelWizard/steps.tsx 14.63% <0.00%> (-0.37%) ⬇️
.../costModels/createCostModelWizard/wizard.styles.ts 100.00% <ø> (ø)
.../routes/costModels/createCostModelWizard/index.tsx 22.83% <12.50%> (-0.50%) ⬇️
.../costModels/createCostModelWizard/distribution.tsx 53.33% <53.33%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32530a9...f4d7fdb. Read the comment docs.

Copy link
Contributor

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the backend pushed support to stage and/or prod? I noticed the cost-model request didn't error with the new properties.

If the backend isn't ready, you could wrap this feature in an Unleash toggle? That way, we can merge your code to main.

@@ -1461,6 +1495,12 @@ export default defineMessages({
'https://access.redhat.com/documentation/en-us/cost_management_service/2022/html-single/using_cost_models/index#cost-model-terminology',
id: 'docsCostModelTerminology',
},
docsCostModelsDistribution: {
defaultMessage:
'https://access.redhat.com/documentation/en-us/cost_management_service/2022/html/using_cost_models/assembly-setting-up-cost-models#creating-an-AWS-Azure-cost-model_setting-up-cost-models',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL takes me to the same place as the "learn more" link used in the previous step.

See the docsConfigCostModels message

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sketches currently have the same URL listed in both places https://www.sketch.com/s/cc6b3d35-a41c-4810-bdd8-4f70a6a3e4e5/a/AxvKMPr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm with Natalie/Ben. Maybe that is just a placeholder, but don't believe the two steps should reference the same link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did add a new placeholder... same url but using a unique intl message so when we get a new url we can just replace it there.

@gitdallas
Copy link
Collaborator Author

gitdallas commented Nov 8, 2022

@dlabrecq - looking at putting this behind unleash... i've kinda had to move things around a bit and if i have this as a flag, i'm not 100% sure how to go about it. would i keep all the changes and just hide the two new options?

@gitdallas gitdallas marked this pull request as ready for review November 10, 2022 16:48
@gitdallas gitdallas changed the title feat(CostModelWizard): 3145 distribution step feat(CostModelWizard): 3145 distribution step (crawl) Nov 10, 2022
@gitdallas gitdallas merged commit 64d35f5 into project-koku:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants