New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include cost models info on get/list provider response #1418
Conversation
6353b1c
to
a45edee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Please post a demo when you have the chance.
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
========================================
Coverage ? 96.1%
========================================
Files ? 208
Lines ? 11473
Branches ? 1280
========================================
Hits ? 11030
Misses ? 272
Partials ? 171 |
cf8fa8c
to
181fa2b
Compare
Demo of API changes: https://asciinema.org/a/282875 |
Coverage increased (+0.004%) to 96.685% when pulling 59eabe3fbc404d01b84ab8fc9c59ff388a1b5a4e on 1051-provider-cost-model into c00738c on master. |
59eabe3
to
8c316c2
Compare
Code Climate has analyzed commit 8c316c2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 97.6%. View more on Code Climate. |
for #1051