Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include cost models info on get/list provider response #1418

Merged
merged 1 commit into from Nov 22, 2019

Conversation

infinitewarp
Copy link
Contributor

for #1051

@infinitewarp infinitewarp requested a review from a team November 18, 2019 18:33
@infinitewarp infinitewarp force-pushed the 1051-provider-cost-model branch 2 times, most recently from 6353b1c to a45edee Compare November 18, 2019 19:34
werwty
werwty previously approved these changes Nov 18, 2019
Copy link
Contributor

@werwty werwty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Please post a demo when you have the chance.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@89596ee). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #1418   +/-   ##
========================================
  Coverage          ?   96.1%           
========================================
  Files             ?     208           
  Lines             ?   11473           
  Branches          ?    1280           
========================================
  Hits              ?   11030           
  Misses            ?     272           
  Partials          ?     171

@infinitewarp
Copy link
Contributor Author

Demo of API changes: https://asciinema.org/a/282875

blentz
blentz previously approved these changes Nov 22, 2019
@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage increased (+0.004%) to 96.685% when pulling 59eabe3fbc404d01b84ab8fc9c59ff388a1b5a4e on 1051-provider-cost-model into c00738c on master.

@codeclimate
Copy link

codeclimate bot commented Nov 22, 2019

Code Climate has analyzed commit 8c316c2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 97.6%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants