-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-1471] Create AWS Service/Region Resource Types #2904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2904 +/- ##
======================================
Coverage 95.0% 95.0%
======================================
Files 295 297 +2
Lines 23605 23647 +42
Branches 2632 2632
======================================
+ Hits 22431 22476 +45
+ Misses 704 701 -3
Partials 470 470 |
Fozzywozzybear
changed the title
Add 2 new endpoints for /resource-types /aws-service and /aws-region
Add 2 new endpoints for /resource-types /aws-service and /aws-region [COST-1471] <Create AWS Service/Region Resource Types>
Jun 2, 2021
Fozzywozzybear
changed the title
Add 2 new endpoints for /resource-types /aws-service and /aws-region [COST-1471] <Create AWS Service/Region Resource Types>
[COST-1471] <Create AWS Service/Region Resource Types>
Jun 2, 2021
Fozzywozzybear
changed the title
[COST-1471] <Create AWS Service/Region Resource Types>
[COST-1471] Create AWS Service/Region Resource Types
Jun 2, 2021
dlabrecq
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dccurtis
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two new endpoints show data from the service the user is running and also can show the regions the user has cloud services running. These two endpoints also support searching and ordered in ascending order.
Steps to test
=========
10 failed, 5939 passed, 13 skipped, 705 deselected in 3394.78s (0:56:34)
FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_aws_instance_reports.py::test_api_aws_instance_or_group_bys_daily[instance_types] - Assertio... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_azure_cost_reports.py::test_api_azure_cost_tag_validate_keys_visible - AssertionError: Faili... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_cost_model.py::test_api_cost_model_recalc_window - AssertionError: assert {'clusters': ...':... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_gcp_instance_reports.py::test_api_gcp_instance_or_group_bys_daily[instance_types] - Assertio... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_tag_multiple_validate_total FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-10-days] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-30-days] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-month-daily] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[two-months-ago-daily] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_user.py::test_api_settings_aws_tag_enablement - AssertionError: assert 'green' == 'no-enviro...