Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-1471] Create AWS Service/Region Resource Types #2904

Merged
merged 16 commits into from
Jun 15, 2021
Merged

Conversation

Fozzywozzybear
Copy link
Contributor

These two new endpoints show data from the service the user is running and also can show the regions the user has cloud services running. These two endpoints also support searching and ordered in ascending order.

Steps to test

  1. Create and load test data
  2. Go to http://localhost:8000/api/cost-management/v1/resource-types/aws-service/ adding ?search= to the end to search for the data, Example, ?search=AmazonEC will only show results with AmazonEc and order them in ascending order. You can also type in just ?search=ama and this will show results with the letters ama in them.
  3. Go to http://localhost:8000/api/cost-management/v1/resource-types/aws-region/ adding ?search to the end to search for data, Example, ?search=EU will only show results that are from EU. You can also type in just E and this will show ressults with the letter E in them.
  4. Note, this search is not case sensitive.
    =========
    10 failed, 5939 passed, 13 skipped, 705 deselected in 3394.78s (0:56:34)
    FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_aws_instance_reports.py::test_api_aws_instance_or_group_bys_daily[instance_types] - Assertio... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_azure_cost_reports.py::test_api_azure_cost_tag_validate_keys_visible - AssertionError: Faili... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_cost_model.py::test_api_cost_model_recalc_window - AssertionError: assert {'clusters': ...':... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_gcp_instance_reports.py::test_api_gcp_instance_or_group_bys_daily[instance_types] - Assertio... FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_tag_multiple_validate_total FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-10-days] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-30-days] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[last-month-daily] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_ocp_on_azure_storage_reports.py::test_api_ocp_on_azure_storage_date_range_report_filter_match_date_range_tag[two-months-ago-daily] FAILED lib64/python3.6/site-packages/iqe_cost_management/tests/rest_api/v1/test_user.py::test_api_settings_aws_tag_enablement - AssertionError: assert 'green' == 'no-enviro...

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #2904 (3deca5f) into master (879061b) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master   #2904   +/-   ##
======================================
  Coverage    95.0%   95.0%           
======================================
  Files         295     297    +2     
  Lines       23605   23647   +42     
  Branches     2632    2632           
======================================
+ Hits        22431   22476   +45     
+ Misses        704     701    -3     
  Partials      470     470           

@Fozzywozzybear Fozzywozzybear marked this pull request as ready for review June 1, 2021 20:50
@Fozzywozzybear Fozzywozzybear changed the title Add 2 new endpoints for /resource-types /aws-service and /aws-region Add 2 new endpoints for /resource-types /aws-service and /aws-region [COST-1471] <Create AWS Service/Region Resource Types> Jun 2, 2021
@Fozzywozzybear Fozzywozzybear changed the title Add 2 new endpoints for /resource-types /aws-service and /aws-region [COST-1471] <Create AWS Service/Region Resource Types> [COST-1471] <Create AWS Service/Region Resource Types> Jun 2, 2021
@Fozzywozzybear Fozzywozzybear changed the title [COST-1471] <Create AWS Service/Region Resource Types> [COST-1471] Create AWS Service/Region Resource Types Jun 2, 2021
Copy link
Contributor

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fozzywozzybear Fozzywozzybear merged commit 19bffc5 into master Jun 15, 2021
@maskarb maskarb deleted the Cost_1471 branch September 2, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants