[COST-3337] - order subquery deletes/updates

[maskarb]

Jira Ticket

COST-3337

Description

The table that tends to cause deadlocks is reporting_ocptags_values. This PR changes the UPDATEs and DELETEs on this table to an ordered subquery with a locking clause.

Testing

1. smokes I suppose (not sure how to manually replicate this issue)

Notes

Here are some resources that led me to these changes:

• https://www.cockroachlabs.com/blog/select-for-update/
• https://stackoverflow.com/a/27015834
• https://www.postgresql.org/docs/current/sql-select.html#SQL-FOR-UPDATE-SHARE

[maskarb]

/retest

[codecov]

Codecov Report

Merging #4250 (b5d19d4) into main (664d436) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4250   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        382     382           
  Lines      32237   32237           
  Branches    3445    3445           
=====================================
  Hits       30347   30347           
- Misses      1238    1240    +2     
+ Partials     652     650    -2     

[maskarb]

/retest