Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4662] Map Azure columns to expected names from TRINO_REQUIRED_COLUMNS #4930

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Feb 21, 2024

Jira Ticket

COST-4662

Description

This change will map some Azure column names to the expected columns from TRINO_REQUIRED_COLUMNS. These are the columns relevant to both Cost Management processing as well as the RHEL Metering work.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Load data created from an RG level cost export
  4. Watch the data load and make sure there are no errors. Verify that the resourceid field in Trino is filled in with the values from the InstanceName column in the RG export.
  5. Load data created from a non-RG level cost export and verify there are no errors.

Notes

...

@cgoodfred cgoodfred added the azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests label Feb 21, 2024
@cgoodfred cgoodfred self-assigned this Feb 21, 2024
@cgoodfred
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #4930 (1f153d7) into main (5440cac) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4930     +/-   ##
=======================================
- Coverage   94.0%   94.0%   -0.0%     
=======================================
  Files        375     375             
  Lines      31013   31015      +2     
  Branches    3685    3685             
=======================================
- Hits       29160   29157      -3     
- Misses      1181    1185      +4     
- Partials     672     673      +1     

@cgoodfred cgoodfred marked this pull request as ready for review February 21, 2024 15:18
@cgoodfred cgoodfred requested review from a team as code owners February 21, 2024 15:18
@esebesto
Copy link
Contributor

esebesto commented Mar 1, 2024

/retest

@cgoodfred cgoodfred merged commit f65a181 into main Mar 1, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4662-map-azure-fields branch March 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-smoke-tests pr_check will build the image and run azure + ocp on azure smoke tests smokes-required
Projects
None yet
3 participants