[COST-4390] OCP changing GB to GiB #4938
Conversation
|
/retest |
bacciotti
force-pushed
the
COST4390-ocp-units
branch
from
f8576fe
to
4e5cd3d
Compare
|
/retest |
bacciotti
force-pushed
the
COST4390-ocp-units
branch
from
9898fed
to
7d46911
Compare
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4938 +/- ##
=====================================
Coverage 94.0% 94.0%
=====================================
Files 375 375
Lines 31129 31129
Branches 3698 3698
=====================================
Hits 29266 29266
- Misses 1189 1191 +2
+ Partials 674 672 -2 |
|
/retest |
myersCody
changed the title
|
/retest |
1 similar comment
|
/retest |
bacciotti
added
the
smoke-tests
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
ci/functions.sh
Outdated
| @@ -127,7 +127,7 @@ function run_smoke_tests_stage() { | |||
| echo "Running E2E tests with IQE:" | |||
| echo "IQE_MARKER_EXPRESSION: '$IQE_MARKER_EXPRESSION'" | |||
| echo "IQE_FILTER_EXPRESSION: '$IQE_FILTER_EXPRESSION'" | |||
|
|
|||
| export IQE_IMAGE_TAG="cost-management-1891-e26f8349" | |||
There was a problem hiding this comment.
Curious why we are adding this IQE_IMAGE_TAG?
There was a problem hiding this comment.
@djnakabaale this is a temporary solution to run this PR against a modified iqe plugin version :)
There was a problem hiding this comment.
@bacciotti would you be interested in documenting how you created the tag and how you can use this env var to run the smokes off a modified version? I think it could be helpful for the team moving forward.
There was a problem hiding this comment.
Sure I would! I can do that!
There was a problem hiding this comment.
FTI I've created a document explaining this. Please ping me on slack, then I can send you.
|
/retest |
|
/retest |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Removing image qe tag.
|
linty lint is sad |
samdoran
changed the title
Inserting new image-tag
|
Tested locally - clean pass with full smokes |
Jira Ticket
COST-4390
Description
This change will change "GB" units for "GiB" units on OCP.