Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4727] Fix tag mapping parent child filters. #4954

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

myersCody
Copy link
Contributor

@myersCody myersCody commented Mar 1, 2024

Jira Ticket

COST-4727

Description

This change will update the parent & child filters for tag mapping to be based on the tag keys instead of uuid.

Testing

Add some tag tag mappings then hit:

http://localhost:8000/api/cost-management/v1/settings/tags/mappings/?filter[parent]=p
http://localhost:8000/api/cost-management/v1/settings/tags/mappings/?filter[child]=a

Notes

...

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Merging #4954 (6f2786b) into main (91b049b) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4954   +/-   ##
=====================================
  Coverage   94.0%   94.0%           
=====================================
  Files        375     375           
  Lines      31033   31035    +2     
  Branches    3688    3688           
=====================================
+ Hits       29173   29176    +3     
+ Misses      1186    1185    -1     
  Partials     674     674           

@myersCody myersCody marked this pull request as ready for review March 3, 2024 21:52
@myersCody myersCody requested review from a team as code owners March 3, 2024 21:52
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Mar 4, 2024
@myersCody myersCody merged commit 679d29d into main Mar 4, 2024
11 checks passed
@myersCody myersCody deleted the COST-4727-fix-filters branch March 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
2 participants