[COST-4394] Fixing OCI GB and TB calculations #4974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4394
Description
This change will fix the calculations regarding the OCI conversion from
bytes
toGigabytes
and fromTerabytes/millisecond
toGigabytes/Month
, considering that we are using the Decimal Standard, and we have stated that we should use the GB unit.In the former code,
power(2, -30)
is used, which is equivalent todividing by 2^30
. This is the conversion factor forbytes
toGibibytes (GiB)
, where1 GiB = 2^30 bytes
.This change will fix it, replacing by
* power(10, -9)
, which is equivalent to dividing by 10^9. This is the conversion factor forbytes
toGigabytes (GB)
, where1 GB = 10^9 bytes
.When it comes to the
TB_MS
side, according to the Decimal Standard, we have tomultiply by 1000
instead of1024
(which would convert toGiB
).