Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4750] Fix regression caused by bad cast in trino #4977

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-4750

Description

This change will fix the regression I caused with a bad cast option in trino.

Testing

SELECT cast(coalesce(NULL, CAST('{}' AS JSON)) as map(varchar, varchar));

versus

SELECT cast(coalesce(NULL, cast(map(array[], array[]) as json)) as map(varchar, varchar));

Notes

...

@myersCody myersCody added the ocp-smoke-tests pr_check will build the image and run ocp + ocp on [clouds] smoke tests label Mar 15, 2024
@myersCody myersCody self-assigned this Mar 15, 2024
@myersCody myersCody requested review from a team as code owners March 15, 2024 17:06
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #4977 (86db6de) into main (9a88d07) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4977     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        375     375             
  Lines      31170   31170             
  Branches    3704    3704             
=======================================
- Hits       29327   29324      -3     
- Misses      1176    1179      +3     
  Partials     667     667             

@myersCody myersCody merged commit 4f12cbc into main Mar 15, 2024
11 checks passed
@myersCody myersCody deleted the COST-4750-fix-regression branch March 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ocp-smoke-tests pr_check will build the image and run ocp + ocp on [clouds] smoke tests smokes-required
Projects
None yet
2 participants