Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4762] Update HCS AWS Estimate pricing #4979

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Mar 18, 2024

Jira Ticket

COST-4762

Description

This change will update HCS pricing estimates for AWS CCSP data.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Create and Load the AWS test customer data
  4. Check the minio bucket for HCS data for your AWS source and verify that the lineitem_unblendedcost field contains values based on lineitem_usageamount and product_vcpu as specified in the ticket

Release Notes

  • proposed release note
* [COST-4762](https://issues.redhat.com/browse/COST-4762) Update AWS HCS pricing estimate calculations

@cgoodfred cgoodfred self-assigned this Mar 18, 2024
@cgoodfred cgoodfred added the BLOCKED This issue is currently blocked. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (45683f9) to head (378bca3).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4979     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        377     377             
  Lines      31331   31331             
  Branches    3714    3714             
=======================================
- Hits       29495   29493      -2     
- Misses      1169    1172      +3     
+ Partials     667     666      -1     

@cgoodfred cgoodfred added aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests and removed BLOCKED This issue is currently blocked. labels Apr 15, 2024
@cgoodfred cgoodfred marked this pull request as ready for review April 15, 2024 12:43
@cgoodfred cgoodfred requested review from a team as code owners April 15, 2024 12:43
@cgoodfred cgoodfred added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed aws-smoke-tests pr_check will build the image and run aws + ocp on aws smoke tests labels Apr 26, 2024
@cgoodfred
Copy link
Contributor Author

Running hot fix smokes since this requires an update to the HCS smokes.

@cgoodfred cgoodfred merged commit 6791b08 into main Apr 26, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4762-HCS-estimate-update branch April 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
2 participants