Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add provider-billing-source to sources masu endpoint #4984

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Mar 19, 2024

Jira Ticket

COST-####

Description

This change will return the ProviderBillingSource information in masu, in addition to the pks of the authentication and billing info because these are more useful that the unused uuids in these tables.

Testing

  1. http://localhost:5042/api/cost-management/v1/sources/
  2. in the provider field, see:
            "provider": {
                "uuid": "9bf22647-e18e-4b63-acb3-8ec3ad77330a",
                ....
                "authentication": {
                    "id": 13, <<<<<<<<<<< this is `id` instead of `uuid` now
                    "credentials": {
                        "role_arn": "arn:aws:iam::111111111111:role/CostManagement"
                    }
                },
                "billing_source": { <<<<<<<<< this was missing
                    "id": 10,
                    "data_source": {
                        "bucket": "/tmp/local_bucket_1"
                    }
                },
                ...

## Notes

...

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #4984 (ae953ec) into main (77dbb76) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4984     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        377     377             
  Lines      31321   31327      +6     
  Branches    3711    3711             
=======================================
+ Hits       29478   29483      +5     
  Misses      1174    1174             
- Partials     669     670      +1     

@maskarb maskarb added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label Mar 19, 2024
@maskarb
Copy link
Member Author

maskarb commented Mar 19, 2024

/retest

@maskarb maskarb enabled auto-merge (squash) April 4, 2024 14:12
@maskarb maskarb merged commit 4383f05 into main Apr 9, 2024
11 checks passed
@maskarb maskarb deleted the provider-billing-source-masu branch April 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
2 participants