Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4423] - fix manifest updates for cluster info #5000

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Mar 26, 2024

Jira Ticket

COST-4423

Description

This change will fix which manifest is getting updated during summary flows, we wanted to add provider_uuid as part of OCP on Cloud summary tasks so we could update the latest OCP manifest for the cluster info pages.

The only downside of switching back some of this is the report_data (re-summary) endpoint would update the latest manifest for whichever provider was triggered. This endpoint in a future update we could consider adopting this manifest lookup in order to pass in the correct manifest for these summary tasks.

Testing

  1. Checkout Branch
  2. Restart Koku with multiple workers
  3. Ingest OCP data and send a second payload mid summary
  4. We should continue to update the correct manifest mid processing

Release Notes

  • proposed release note
* [COST-4423](https://issues.redhat.com/browse/COST-4423) Fix which manifest is getting updated during summary flows specifically for OCP on Cloud tasks.

@lcouzens lcouzens requested review from a team as code owners March 26, 2024 14:29
@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Mar 26, 2024
@lcouzens lcouzens force-pushed the COST-4423-manifest-id-improvements branch from 10f9518 to 724cf1a Compare March 26, 2024 14:48
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #5000 (724cf1a) into main (28ce640) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5000   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        375     375           
  Lines      31165   31170    +5     
  Branches    3706    3706           
=====================================
+ Hits       29319   29324    +5     
+ Misses      1179    1178    -1     
- Partials     667     668    +1     

@lcouzens lcouzens merged commit 030e68e into main Mar 26, 2024
11 checks passed
@lcouzens lcouzens deleted the COST-4423-manifest-id-improvements branch March 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
2 participants