Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4807] Remove remove-stale from enabled tags masu endpoint options #5007

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Mar 29, 2024

Jira Ticket

COST-4807

Description

This change will remove the remove-stale action from the enabled tags masu endpoint to address a high impact SNYK alert.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Try to post a remove_stale action to the masu endpoint: /api/cost-management/v1/enabled_tags/
{
    "schema": "org1234567",
    "action": "remove_stale",
    "provider_type": "aws"
}
  1. Verify that you are unable to do so.

Release Notes

  • proposed release note
* [[COST-4807]](https://issues.redhat.com/browse/COST-4807) Remove the remove-stale action from the enabled tags masu endpoint.

@cgoodfred cgoodfred added the smoke-tests pr_check will build the image and run minimal required smokes label Mar 29, 2024
@cgoodfred cgoodfred self-assigned this Mar 29, 2024
@cgoodfred cgoodfred requested review from a team as code owners March 29, 2024 16:05
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #5007 (08e5f39) into main (81f259e) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5007   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        377     377           
  Lines      31243   31230   -13     
  Branches    3710    3709    -1     
=====================================
- Hits       29398   29387   -11     
  Misses      1174    1174           
+ Partials     671     669    -2     

@cgoodfred cgoodfred enabled auto-merge (squash) April 8, 2024 19:34
@cgoodfred cgoodfred merged commit 1aef108 into main Apr 8, 2024
11 checks passed
@cgoodfred cgoodfred deleted the COST-4807-enabled-tags branch April 8, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
2 participants