[COST-4715] sentry -> glitchtip cleanup p1 #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
force-pushed
the
COST-4715-cleanup
branch
from
5d5b8fe
to
bbcb95a
Compare
maskarb
force-pushed
the
COST-4715-cleanup
branch
from
2ef7837
to
4a12de0
Compare
maskarb
added
the
hot-fix-smoke-tests
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5010 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 377 377
Lines 31233 31233
Branches 3708 3708
=====================================
Hits 29380 29380
Misses 1181 1181
Partials 672 672 |
djnakabaale
reviewed
Apr 1, 2024
| traces_sampler=traces_sampler, | ||
| ) | ||
| LOG.info("Sentry setup.") | ||
| # TODO: remove the following in favor of the above `if` |
There was a problem hiding this comment.
Do you plan to remove this TODO in a followup pr?
There was a problem hiding this comment.
Yes, these cannot be removed until the other envs are switched to use the new variables.
| @@ -34,6 +42,7 @@ def traces_sampler(sampling_context): | |||
| traces_sampler=traces_sampler, | |||
| ) | |||
| LOG.info("Sentry setup.") | |||
| # TODO: remove the following in favor of the above `if` | |||
There was a problem hiding this comment.
Do you plan to remove this TODO in a followup pr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-4715
Description
API_SENTRY_DSN_KEY,CELERY_SENTRY_DSN_KEY,LISTENER_SENTRY_DSN_KEY,SOURCE_SENTRY_DSN_KEYwithGLITCHTIP_KEY_NAMEKOKU_ENABLE_SENTRY,KOKU_SENTRY_DSN, andKOKU_SENTRY_ENVIRONMENT) which will consolidate several different SENTRY env variables.This PR is written so that the old variables are still used. Once we switch stage/prod over to the new variables, we can remove them entirely.
Release Notes