This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Feature: sound interface #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roelemans
approved these changes
Jan 15, 2020
|
How will you schedule sounds to be played at a certain part of a gait? |
This will still be possible from the state machine, gait selection or gait scheduler even. |
JorisWeeda
approved these changes
Jan 17, 2020
Merged
RutgerVanBeek
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Feature: sound interface (#436) * Added sound_play sounds to safety * Removed sound scheduler * Add sound_play_node to launch file * Several small fixes * Fix clang format * Remove sound scheduler exec depend * Clang tidy fixes * Feature/pm246 stairs in sim (#439) * Fix undefined value in xacro when launching on exo. * Add stairs to simulation Co-authored-by: Olav de Haas <olavh@protonmail.com> * Feature/pm 249 add rockerswitch input (#438) * Added rocker switch variable to the gait instruction msg generated by the (mock) input device. The message can send a 1 which means that the rocker switch has been incremented and a -1 which means that the rocker switch has been decremented. * Added two more variables to the gait instruction message to distinguish increment or decrement of the rocker switch. * Removed the rocker switch argument and created the increment and decrement possibilities as instruction types. Co-authored-by: Roelemans <47626418+Roelemans@users.noreply.github.com> Co-authored-by: JorisWeeda <45165354+JorisWeeda@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PM-158
Description
This PR removes the
march_sound_schedulerpackage and uses the ROSsound_playdirectly to play sounds. Since all themarch_sound_schedulerpackage did was receive messages about sounds and passing them on to thesound_playnode.sound_playhas a good library interface for both Python and C++. The sounds are moved to themarch_safetypackage which loads and plays them.Changes
march_sound_schedulersounddirectory inmarch_safety, which contains the fatal and non fatal soundsmarch_safetycode anyway