feat: Apache NiFi integration support #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does
aws-ignore-auth-header-region
flag toserve
commandCredential
part of theAuthorization
header.Why
This change is motivated by the integration with Apache NiFi. When NiFi
*S3
processors make a request to Sidekick theAuthorization
header of the incoming request looks likeThe interesting part here is
Credential
which we use to deduce the region to use when creating requests going to Crunch and AWS. Despite configuring the regions in each processor (and some under the hood NiFi configs), the Credential part looks likeand the inferred region is
us-east-1
while the bucket actually resides inus-west-2
.After this change, we're able to force the region specified via the
GRANICA_REGION
env var explicitly and get NiFi working