Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-7182: Inherit environment variables #385

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

dwalluck
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #385 (614916c) into main (debd457) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff            @@
##               main     #385   +/-   ##
=========================================
  Coverage     66.02%   66.02%           
- Complexity      405      406    +1     
=========================================
  Files            41       41           
  Lines          2084     2087    +3     
  Branches        292      294    +2     
=========================================
+ Hits           1376     1378    +2     
  Misses          604      604           
- Partials        104      105    +1     
Impacted Files Coverage Δ
cli/src/main/java/org/jboss/gm/cli/Main.java 70.00% <77.77%> (-1.34%) ⬇️
.../gm/manipulation/actions/ManifestUpdateAction.java 51.92% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debd457...614916c. Read the comment docs.

@dwalluck
Copy link
Contributor Author

All tests pass, so if the issue in 6e2c842 (gradle/gradle#3117) is being tested, that is fixed as well.

@dwalluck dwalluck requested a review from rnc July 11, 2022 14:30
@rnc rnc merged commit d449a03 into project-ncl:main Jul 18, 2022
@dwalluck dwalluck deleted the NCL-7182 branch July 18, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants